Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore stack-like behavior of parseGLIF transform pointer #1595

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

skef
Copy link
Collaborator

@skef skef commented Jan 5, 2023

Also Fix ancient transform->isDefault logic error.

Description

What it says on the tin.

Checklist:

  • I have followed the Contribution Guidelines
  • I have added test code and data to prove that my code functions correctly
  • I have verified that new and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Fix ancient transform->isDefault logic error.
@skef skef requested a review from cjchapman January 5, 2023 04:25
Copy link
Contributor

@cjchapman cjchapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Note about the test failures:

There seems to be some new issue with the (macos-latest, 3.10) tests, but as far as I can tell, it's a CI issue, and not a code issue. The tests passed locally on my M1 mac with Python 3.10.8.

There's also an older CI issue with the (windows-latest, 3.10) tests (see #1581).

@cjchapman cjchapman merged commit df7e5b1 into develop Jan 5, 2023
@cjchapman cjchapman deleted the transstack branch January 5, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants