Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify cmake libxml build logic #1597

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Unify cmake libxml build logic #1597

merged 1 commit into from
Jan 10, 2023

Conversation

skef
Copy link
Collaborator

@skef skef commented Jan 9, 2023

... and add environment variable to force static link of libxml2

Description

The GitHub windows build has been failing because CMake finds a stray, poorly
matching version of LibXML2. This PR centralizes the LibXML2 build logic and adds
two environment variables, one to force downloading and static linking against
the library one to force use of the system library. The former is used for GitHub
windows builds.

Checklist:

  • I have followed the Contribution Guidelines
  • I have added test code and data to prove that my code functions correctly
  • I have verified that new and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Add environment variable to force static link of libxml2
@skef skef requested a review from kaydeearts January 9, 2023 15:31
Copy link
Collaborator

@kaydeearts kaydeearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 awesome!

@skef skef merged commit 50e9d40 into develop Jan 10, 2023
@skef skef deleted the xmllibover branch January 10, 2023 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants