Stop forcing static LibXML2 build on Linux

[skef]

Checklist:

• I have followed the Contribution Guidelines
• I have added test code and data to prove that my code functions correctly
• I have verified that new and existing tests pass locally with my changes
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation

[kaydeearts]

Just a question: are we keeping this uncommented so users can force a static installation if needed, or for our own references in the future? If we're going to keep it as a comment, could we add a sentence here or in the docs what these commented lines do?

[skef]

The first thing I would say is that the github workflows are pretty much entirely "ours" -- the contents of these files have no impact on "downstream" users, except perhaps in the sense that users who clone the repo on github itself might activate workflows (but probably not this one, since I don't think we trigger it ourselves except at release time).

I suppose I kept the commented lines as a reference for how to build a wheel on "GitHub-world" Linux dynamically linked to LibXML2. You tracked that info down at some point, and even if we've decided it doesn't work it may be useful down the road.

As for comments my view is that because the lines below include setting FORCE_BUILD_LIBXML2 it's pretty clear what's going on, but YMMV.

[josh-hadley]

This is indeed a new flake8 warning and adding it to ignore is fine for now but reading it I think we should probably make some efforts to update the test code (per the flake8 warning: be more specific than pytest.raises(Exception) – use the specific Exception that is expected to be raised) and remove B017 from the ignore list once the affected tests are updated.

[skef]

yeah, I added this because it suddenly appeared and was causing the tests to fail. I'm fine with fixing it when we have time.

[kaydeearts]

Looks good to me with your comments on my question + agreement on fixing flake8 errors once we have time in the future (but we should make a separate issue for that)