Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force static link of libxml2 on both windows and linux #1607

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Force static link of libxml2 on both windows and linux #1607

merged 1 commit into from
Feb 1, 2023

Conversation

skef
Copy link
Collaborator

@skef skef commented Jan 31, 2023

Description

What it says on the tin.

Checklist:

  • I have followed the Contribution Guidelines
  • I have added test code and data to prove that my code functions correctly
  • I have verified that new and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@skef
Force static link of libxml2 on both windows and linux
ec0fa2d 
(Using the all-environments CIBW_ENVIRONMENT setting.)
kaydeearts
kaydeearts approved these changes Jan 31, 2023
View reviewed changes
Copy link
Collaborator

@kaydeearts kaydeearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it should work, so approving for now and waiting for gitlab.gnome to come back online

@skef skef merged commit fc50a5f into develop Feb 1, 2023
@skef skef deleted the winwheel branch February 1, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaydeearts kaydeearts kaydeearts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skef @kaydeearts