[spot] fix 'kern' subtable Format3 rightClass memory leak (double allocation). #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaydeearts
approved these changes
Mar 21, 2023
There was a problem hiding this comment.
I tested this locally and it worked — thank you for your contribution, @NSGod !
|
@kaydeearts: Sorry, I'm a bit new to this: should I close the bug (issue) I made or are only you supposed to do that, or it doesn't really matter and either one of us can do it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a bug fix for #1626 [spot] kern.c memory leak.
Checklist:
Regarding the following checklist, I've tried to get the tests to run and pass locally for me and I can't seem to get that working despite switching to Python 3.10 (from 3.11; that actually made it worse). The failures seem consistent and AFAICT, aren't related to
spot. I'm hoping you guys can test on your end to confirm?The last 2 don't really seem applicable to such a minor change.