Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to CID-keyed UFO handling #1628

Merged
merged 23 commits into from
Apr 6, 2023
Merged

Updates to CID-keyed UFO handling #1628

merged 23 commits into from
Apr 6, 2023

Commits on Mar 22, 2023

  1. [uforead] use glyphName instead of fileName for glyph search

    @kaydeearts
    kaydeearts committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    86a8991 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2023

  1. Let tx read UFO glyphs by CID like in t1read and cffread.

    @punchcutter
    punchcutter committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    416f508 View commit details
    Browse the repository at this point in the history

  2. Allow glyph names in CID-keyed UFOs

    @punchcutter
    punchcutter committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    3aa6175 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2023

  1. Dump glyph name for CID-keyed UFOs

    @punchcutter
    punchcutter committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    84ce922 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2023

  1. Update tx dump of CID-keyed UFOs with glyph names

    @punchcutter
    punchcutter committed Mar 25, 2023
    Configuration menu
    Copy the full SHA
    4b4343e View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2023

  1. Move setting of CIDCount in uforead to parseCIDMap

    @punchcutter
    punchcutter committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    b461971 View commit details
    Browse the repository at this point in the history

  2. Add orderCIDKeyedGlyphs to keep CID order in UFOs

    @punchcutter
    punchcutter committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    8fca2ae View commit details
    Browse the repository at this point in the history

  3. Remove unused dicts in FDArray

    @punchcutter
    punchcutter committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    d4ee093 View commit details
    Browse the repository at this point in the history

  4. Let CID-keyed UFO -> Type 1 name-keyed conversion maintain glyph name… 

    …s [skip ci]
    @punchcutter
    punchcutter committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    3d5cdd9 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. Update CID-keyed UFO glyph sorting

    @punchcutter
    punchcutter committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    be24ebf View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. [tx_test] A duplicate glif with the same name no longer creates this … 

    …warning because the dup glif is discarded earlier when calling findGLIFRecByName(h, glyphName). Previously, this was searching by fileName rather than glyphName.
    @kaydeearts
    kaydeearts committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    ba2e048 View commit details
    Browse the repository at this point in the history

  2. [absfont_dump] Ubuntu flake8 fixes

    @kaydeearts
    kaydeearts committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    a526a83 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. [tx_test] Add test case with running decid on cid UFO with FDArray

    @kaydeearts
    kaydeearts committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    c5287a1 View commit details
    Browse the repository at this point in the history

  2. [tx_shared] Properly re-alloc memory for selected FD and free the pre… 

    …vious memory. More work needed for this in the future.
    @kaydeearts
    kaydeearts committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    17e6879 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2023

  1. [tx_shared.c] Should not assume memory is allocated for this ptr as w… 

    …e have different inputs and different parsing functions that aren't all consistent yet. Better fixes in the future.
    @kaydeearts
    kaydeearts committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    9c9389a View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. Address code review comments from Skef

    @punchcutter
    punchcutter committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    0d217b6 View commit details
    Browse the repository at this point in the history

  2. [uforead] WARN instead of FAIL when glyph is missing CID number

    @kaydeearts
    kaydeearts committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    8cd1e6d View commit details
    Browse the repository at this point in the history

  3. [tx_data] Fix some tests for fail deprecated to warn

    @kaydeearts
    kaydeearts committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    372b1c3 View commit details
    Browse the repository at this point in the history

  4. [tx_data] Add needed test files

    @kaydeearts
    kaydeearts committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    ba62fdd View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2023

  1. [tx_test] Should use pfb, not pfa, in expected_outputs

    @kaydeearts
    kaydeearts committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    ff5ba8c View commit details
    Browse the repository at this point in the history

  2. [uforead] Check if CID is defined before adding char

    @kaydeearts
    kaydeearts committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    aea404a View commit details
    Browse the repository at this point in the history

  3. [tx_data] fix expected outputs + input for tests, + cpplint fix

    @kaydeearts
    kaydeearts committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    b03357f View commit details
    Browse the repository at this point in the history

  4. [uforead, tx_test] Clarify warning regarding missing CID number

    @kaydeearts
    kaydeearts committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    0d7a5ea View commit details
    Browse the repository at this point in the history