Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.7 #1638

Merged
merged 6 commits into from
Apr 13, 2023
Merged

Drop Python 3.7 #1638

merged 6 commits into from
Apr 13, 2023

Conversation

kaydeearts
Copy link
Collaborator

@kaydeearts kaydeearts commented Apr 12, 2023

Description

⚠️ Starting April 3, 2023, the AFDKO will require Python 3.8 or later. Due to our dependencies already dropping support and requiring Python 3.8 in their latest versions, we will also be dropping Python 3.7 support on April 3, 2023.

Checklist:

  • I have followed the Contribution Guidelines
  • I have added test code and data to prove that my code functions correctly
  • I have verified that new and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@miguelsousa
Copy link
Member

@kaydeearts I've removed 3.7 from the list of required status checks. (GH Settings > Branches > Branch protection rules)

@kaydeearts
Copy link
Collaborator Author

@miguelsousa thanks so much! I was wondering where I could remove that 😄

josh-hadley
josh-hadley previously approved these changes Apr 13, 2023
Copy link
Collaborator

@josh-hadley josh-hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

josh-hadley
josh-hadley previously approved these changes Apr 13, 2023
@kaydeearts
Copy link
Collaborator Author

Bumping fonttools to the latest version requires some test output changes. I'll put that into a different PR and keep this to just dropping Python 3.7.

@kaydeearts kaydeearts merged commit e2f48ed into develop Apr 13, 2023
@kaydeearts kaydeearts deleted the kd-drop-python-3.7 branch April 13, 2023 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants