Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spot] fix name table LANG_TAG_REC_SIZE size definition. #1640

Merged
merged 1 commit into from
Apr 13, 2023
Merged

[spot] fix name table LANG_TAG_REC_SIZE size definition. #1640

merged 1 commit into from
Apr 13, 2023

Conversation

NSGod
Copy link
Contributor

@NSGod NSGod commented Apr 13, 2023

Correcting this definition doesn't actually change the value, since the sizes of the length and offset fields of LangTagRecord are identical to those of the NameRecord.

Description

This is a bug fix for #1636 name table LANG_TAG_REC_SIZE size definition.

Checklist:

  • I have followed the Contribution Guidelines
  • I have added test code and data to prove that my code functions correctly
  • I have verified that new and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Since this doesn't actually have any effective change, I didn't run the tests (which I still haven't been able to get fully working yet).

@NSGod @miguelsousa
[spot] fix name table LANG_TAG_REC_SIZE size definition.
b02d862 
Correcting this definition doesn't actually change the value, since the sizes of the `length` and `offset` fields of `LangTagRecord` are identical to those of the `NameRecord`.
@miguelsousa miguelsousa linked an issue Apr 13, 2023 that may be closed by this pull request
[spot] name table LANG_TAG_REC_SIZE size definition. #1636
Closed
miguelsousa
miguelsousa approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@miguelsousa miguelsousa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@miguelsousa miguelsousa merged commit 3a338d5 into adobe-type-tools:develop Apr 13, 2023
@NSGod NSGod deleted the md-spot-name-table-fix branch April 13, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelsousa miguelsousa miguelsousa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[spot] name table LANG_TAG_REC_SIZE size definition.
2 participants
@NSGod @miguelsousa