Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotconv] 'name': fix memory leak in addName() #1646

Merged
merged 1 commit into from
Apr 25, 2023
Merged

[hotconv] 'name': fix memory leak in addName() #1646

merged 1 commit into from
Apr 25, 2023

Conversation

NSGod
Copy link
Contributor

@NSGod NSGod commented Apr 25, 2023

Description

This fixes #1643 [hotconv] 'name': memory leak in addName().

Checklist:

  • I have followed the Contribution Guidelines
  • I have added test code and data to prove that my code functions correctly
  • I have verified that new and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

As I've mentioned before, I still don't have testing figured out locally on my end, so I'll submit this and see how the tests do on your end.

kaydeearts
kaydeearts approved these changes Apr 25, 2023
View reviewed changes
Copy link
Collaborator

@kaydeearts kaydeearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kaydeearts kaydeearts merged commit 3a2f1de into adobe-type-tools:develop Apr 25, 2023
@NSGod NSGod deleted the md-hotconv-add-name-fix branch April 25, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaydeearts kaydeearts kaydeearts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[hotconv] 'name': memory leak in addName()
2 participants
@NSGod @kaydeearts