Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotconv] reset dsigCnt in hotReuse() so subsequent conversions add full stub 'DSIG' table. #1648

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

NSGod
Copy link
Contributor

@NSGod NSGod commented May 3, 2023

Description

This is a patch to fix bug #1647. Basically, I moved the static dsigCount variable outside the refillDSIG() function, and reset it in hotReuse().

Checklist:

  • I have followed the Contribution Guidelines
  • I have added test code and data to prove that my code functions correctly
  • I have verified that new and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

I think I finally have all local tests working except for test_infinite_loop_with_dflt_lookups_bug965(). That test fails before and after my changes, so I don't think it'd be related.

Unlike the previous bugs I've encountered , this strikes me as one that could probably use a test? The thing is, as I've mentioned elsewhere, I'm not sure if it's possible to trigger this bug using existing tools, and I'm still in the process of learning Python enough to write a test. If you think it warrants a test and could create one, that would certainly help in my learning process.

Copy link
Collaborator

@kaydeearts kaydeearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kaydeearts kaydeearts merged commit e8b0f6d into adobe-type-tools:develop Jun 8, 2023
@NSGod NSGod deleted the md-dsig-stub-fix branch June 9, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants