Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotconv] fix warning for negative TypoLineGap. #1654

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

NSGod
Copy link
Contributor

@NSGod NSGod commented May 14, 2023

Description

This is a fix for #1653.

Checklist:

  • I have followed the Contribution Guidelines
  • I have added test code and data to prove that my code functions correctly
  • I have verified that new and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

I ran tests locally and they all passed except the infinite loop one which always crashes for me.

It seems like it might be useful to have a new test that checks for that warning but I don't yet know enough about the testing framework to be able to write one myself.

@miguelsousa miguelsousa linked an issue May 14, 2023 that may be closed by this pull request
Copy link
Collaborator

@kaydeearts kaydeearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kaydeearts kaydeearts merged commit cb2e003 into adobe-type-tools:develop Jun 8, 2023
@NSGod NSGod deleted the md-typo-line-gap-fix branch June 9, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hotconv] negative TypoLineGap warning checks TypoAscender
2 participants