[sfntedit] Fix bug when attempting to add non-existent file #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh-hadley
changed the title
In sfntedit/source/Efile.c, if `filename` is not found, `fyl` was passed to `fileError` with its `->name` unset, leading to wrong/garbage output error message from `fileError`. Moving the statement that sets `fyl->name` *before* the `fyl->fp == NULL` check fixes it.
josh-hadley
force-pushed
the
jh-1658
branch
from
fa890cf
to
99e1afa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modified sfntedit code to show the correct filename when non-existing file is specified for adding a table (
-amode).Closes #1658
Checklist:
I have made corresponding changes to the documentation