Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ttxn] Make it work with latest FontTools #288

Merged
merged 6 commits into from
Mar 29, 2018
Merged

[ttxn] Make it work with latest FontTools #288

merged 6 commits into from
Mar 29, 2018

Conversation

miguelsousa
Copy link
Member

No description provided.

Copy link
Contributor

@cjchapman cjchapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your changes are OK, but PyCharm's inspections revealed two errors in this file:
in lines 842 & 874: pLookupList is used before it is defined (note, it is defined in other if/else blocks of the method, but not in the blocks in question).

@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@miguelsousa
Copy link
Member Author

@cjchapman I'm done with the changes. The remaining issues are all 'lowercase' related.

@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@adobe-type-tools adobe-type-tools deleted a comment Mar 28, 2018
@cjchapman cjchapman merged commit b9ad237 into master Mar 29, 2018
@cjchapman cjchapman deleted the ttxn-fix branch March 29, 2018 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants