-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ttxn] Make it work with latest FontTools #288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think your changes are OK, but PyCharm's inspections revealed two errors in this file:
in lines 842 & 874: pLookupList is used before it is defined (note, it is defined in other if/else blocks of the method, but not in the blocks in question).
@cjchapman I'm done with the changes. The remaining issues are all 'lowercase' related. |
No description provided.