64bit support #344
Merged
64bit support #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…can stay 32 bit while the rest of the FDK goes 64 bit.
…ls except autohint
Fix all warnings in the main program source code, and errors in the makeotflib. There are still about 200 warnings to fix in makeotflib
Fix all warnings in the main program source for this family of programs. There are still about 200 warnings in the coretype library to fix.
…y used by tx, rotateFont, mergeFonts. There are still about 200 warnings to fix.
There are still about 200 warnings to fix.
…ac OSX and latest Xcode.
There are still several warnings about unused members of struct '_ttc_. I do not want to fix this, as these are due to code for supporting ttc, which is only partially implemented and is currently unused, but which could be useful in the future.
# Conflicts: # afdko/Tools/Programs/sfntdiff/source/numtypes.h # afdko/Tools/Programs/sfntedit/source/Efile.c # afdko/Tools/Programs/sfntedit/source/Eglobal.h # afdko/Tools/Programs/sfntedit/source/main.c # afdko/Tools/Programs/spot/source/BLND.c # afdko/Tools/Programs/spot/source/META.c # afdko/Tools/Programs/spot/source/cmap.c # afdko/Tools/Programs/spot/source/dump.c # afdko/Tools/Programs/spot/source/global.h # afdko/Tools/Programs/spot/source/numtypes.h # afdko/Tools/Programs/spot/source/sfnt.c # afdko/Tools/Programs/spot/source/tto.c # afdko/Tools/Programs/tx/source/tx.c
|
@miguelsousa I am glad to see that this PR can be merged automatically. I was not expecting to merge it into the main branch just yet, as there are two outstanding issues. 1) makeotf has a bug in processing seac operators in the source file, 2) rotateFont has a bug in setting the FontBBox. I currently plan to work on these as soon as I get back to work on Monday afternoon. |
|
@readroberts l'm not going to merge it. You can keep committing to the branch |
Merging the main branch (with a fix in tx) into the 64bit support branch caused all the cppcheck warning fixes to be lost. Restored them.
…in branch. The main and 64bit support branches handled redefinition of a variable differently; the changes make the redefinition consistent.
by adding numtypes.h include file to cffread.h; switch to using spot's internally defined numeric types for consistency.
by adding numtypes.h include file to cffread.h; switch to using spot's internally defined numeric types for consistency.
Windows rejects variable declarations which follow an other kind of statement.
|
@miguelsousa the last tag you just pushed “2.7.0rc” is normalised to a PEP440-compatible version string “2.7.0rc0”, however the latter compares older than the preceding tag which was 2.7.0c6 (“c” is equivalent to “rc”). I’d remove the tag, rerelease as 2.7.0rc7 |
|
👌 |
schriftgestalt
pushed a commit
to schriftgestalt/afdko
that referenced
this pull request
May 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.