Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests #346

Merged
merged 8 commits into from
May 8, 2018
Merged

Integration tests #346

merged 8 commits into from
May 8, 2018

Conversation

miguelsousa
Copy link
Member

No description provided.

@miguelsousa miguelsousa force-pushed the integration-tests branch 3 times, most recently from e50bb52 to 489db59 Compare April 30, 2018 05:26
@miguelsousa miguelsousa changed the base branch from master to develop May 4, 2018 17:44
@miguelsousa
Copy link
Member Author

I've changed the base branch to be develop instead of master.

@miguelsousa
Copy link
Member Author

I've restarted Travis & AppVeyor

cjchapman
cjchapman suggested changes May 8, 2018
View reviewed changes
Copy link
Contributor

@cjchapman cjchapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the AppVeyor issues...
Please make an input folder and an expected_output folder under each *_data folder.
Please use something more clear than DIFF_MODES[0] and DIFF_MODES[1], e.g. DIFF_MODE_DEFAULT, DIFF_MODE_BIN, or DIFF_MODE_TXT.

@miguelsousa miguelsousa force-pushed the integration-tests branch 2 times, most recently from e411419 to a9e30ef Compare May 8, 2018 16:45
@miguelsousa
Copy link
Member Author

The current error message is Path1's kind is file. Path2's kind is folder. Path1 is the expected output whereas Path2 is the result of running the tool (via pytest).

Before, a handful of tests were failing whereas now only tx's test_dump_0_type1_explicit_options is. I don't know if this improvement has something to do with recent changes. I'm going to comment this test for the time being and move on.

@miguelsousa
Copy link
Member Author

@cjchapman I'm done with the changes

@miguelsousa miguelsousa merged commit 9188741 into develop May 8, 2018
@miguelsousa miguelsousa deleted the integration-tests branch May 8, 2018 21:51
@miguelsousa miguelsousa mentioned this pull request May 8, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjchapman cjchapman cjchapman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miguelsousa @cjchapman