Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "CID charsets" #368

Merged
merged 4 commits into from
May 21, 2018
Merged

Remove "CID charsets" #368

merged 4 commits into from
May 21, 2018

Conversation

miguelsousa
Copy link
Member

Partial fix for #264

Copy link
Contributor

@cjchapman cjchapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also a references to "CID charsets" in ProofPDF.py:

kCharsetDir = "CID charsets" # relative path to the parent directory for all the layout and subset files

Please address this. Thanks.

@miguelsousa
Copy link
Member Author

👌

@miguelsousa miguelsousa mentioned this pull request May 17, 2018
@miguelsousa
Copy link
Member Author

Oh fun! Another branch-passes-pr-fails case in AppVeyor land 😖
This time it's all Python-based tooling, I believe.
https://ci.appveyor.com/project/adobe-type-tools/afdko/build/1.0.279
https://ci.appveyor.com/project/adobe-type-tools/afdko/build/1.0.280

@miguelsousa
Copy link
Member Author

@cjchapman I'm done with the changes on this PR

@@ -239,7 +231,7 @@ def CheckEnvironment():
logMsg("or the files referenced by the shell script is missing.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exe_dir is undefined

import time
import traceback

from fontTools.ttLib import TTFont, getTableModule
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add TTLibError to the imports from fontTools.ttLib

traceback.print_exc()
raise FontError("Failed to open and read font file %s. Check file/directory permissions." % path)

if len(data) < 10:
raise FontError("Error: font file was zero size: may be a resource fork font, which this program does not process. <%s>." % path)
if (data[:4] == "OTTO") or (data[:4] == "true") or (data[:4] == "\0\1\0\0"): # it is an OTF/TTF font, can process file directly
try:
ttFont = ttLib.TTFont(path)
ttFont = TTFont(path)
except (IOError, OSError):
raise FontError("Error opening or reading from font file <%s>." % path)
except TTLibError:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TTLibError is undefined -- see comment at top of file about need to import it from fontTools.ttLib

@@ -9,14 +9,13 @@
import traceback

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 30: change fdkScriptsDir = None to fdkSharedDataDir = None

lines 167 - 176: if this is still needed, then change import FDK to import afdko

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean_afdko and check_afdko will be removed when I address #336

@miguelsousa
Copy link
Member Author

Dunno what's going on with the Linux build

@cjchapman
Copy link
Contributor

I'm going to try to sort out the Travis/Linux issue in another branch/PR.

@cjchapman
Copy link
Contributor

...and now Travis/Linux is magically working.

@cjchapman
Copy link
Contributor

@miguelsousa I approve the changes. I leave it to you to squash-and-merge.

@miguelsousa miguelsousa merged commit 62abc4d into develop May 21, 2018
@miguelsousa miguelsousa deleted the cid-charsets branch May 21, 2018 22:31
schriftgestalt pushed a commit to schriftgestalt/afdko that referenced this pull request May 18, 2019
* digiplot integration tests

* Remove 'CID charsets' folder

* Remove code related to 'CID charsets'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants