-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "CID charsets" #368
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also a references to "CID charsets" in ProofPDF.py:
kCharsetDir = "CID charsets" # relative path to the parent directory for all the layout and subset files
Please address this. Thanks.
👌 |
Oh fun! Another branch-passes-pr-fails case in AppVeyor land 😖 |
@cjchapman I'm done with the changes on this PR |
@@ -239,7 +231,7 @@ def CheckEnvironment(): | |||
logMsg("or the files referenced by the shell script is missing.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exe_dir
is undefined
import time | ||
import traceback | ||
|
||
from fontTools.ttLib import TTFont, getTableModule |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add TTLibError
to the imports from fontTools.ttLib
traceback.print_exc() | ||
raise FontError("Failed to open and read font file %s. Check file/directory permissions." % path) | ||
|
||
if len(data) < 10: | ||
raise FontError("Error: font file was zero size: may be a resource fork font, which this program does not process. <%s>." % path) | ||
if (data[:4] == "OTTO") or (data[:4] == "true") or (data[:4] == "\0\1\0\0"): # it is an OTF/TTF font, can process file directly | ||
try: | ||
ttFont = ttLib.TTFont(path) | ||
ttFont = TTFont(path) | ||
except (IOError, OSError): | ||
raise FontError("Error opening or reading from font file <%s>." % path) | ||
except TTLibError: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TTLibError
is undefined -- see comment at top of file about need to import it from fontTools.ttLib
@@ -9,14 +9,13 @@ | |||
import traceback | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 30: change fdkScriptsDir = None
to fdkSharedDataDir = None
lines 167 - 176: if this is still needed, then change import FDK
to import afdko
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clean_afdko
and check_afdko
will be removed when I address #336
Dunno what's going on with the Linux build |
I'm going to try to sort out the Travis/Linux issue in another branch/PR. |
...and now Travis/Linux is magically working. |
@miguelsousa I approve the changes. I leave it to you to squash-and-merge. |
* digiplot integration tests * Remove 'CID charsets' folder * Remove code related to 'CID charsets'
Partial fix for #264