Tx fixes #397
Merged
Tx fixes #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… variable in tx.varread.varread.c This update makes no change in function: it simply renames variables and fields to avoid confusion by developers.
|
@readroberts Please add an integration test that can validate this change. |
|
I will create a small CFF2 font and test snapshotting it. |
|
Noted. Will complete this on Tues. |
schriftgestalt
pushed a commit
to schriftgestalt/afdko
that referenced
this pull request
May 18, 2019
* [tx][varread] Fix issue adobe-type-tools#272: Fix inconsistency of use of regionCount variable in tx.varread.varread.c This update makes no change in function: it simply renames variables and fields to avoid confusion by developers. * [tx][tx_test.py] Add test for reading and snapshotting simple CFF2 VF font to test fix for issue adobe-type-tools#272
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[tx] Fix for issue #272. Fix inconsistency of use of regionCount variable in tx.varread.varread.c