fixes for modules used by tx #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjchapman
force-pushed
the
fix-uforead-issues
branch
from
b97f1be
to
2494e40
Compare
cjchapman
changed the title
miguelsousa
force-pushed
the
fix-uforead-issues
branch
from
64da522
to
84939f7
Compare
|
@cjchapman I'm going to add a test case for the trademark string handling |
automatically converted tabs to spaces using Sublime Text 3
…nce cases identified by Xcode
removed all unused code, removed all code that has no effect, fixed some long vs. int issues, added a missing switch case
(the original code was incorrectly setting the pointer to the copyright symbol character to NULL, rather than the character itself) [this is cjchapman borrowing msousa's computer]
miguelsousa
force-pushed
the
fix-uforead-issues
branch
from
08a0880
to
f30efd0
Compare
miguelsousa
force-pushed
the
fix-uforead-issues
branch
from
13acc64
to
2a48d6b
Compare
|
@cjchapman I think this is ready to merge |
schriftgestalt
pushed a commit
to schriftgestalt/afdko
that referenced
this pull request
May 18, 2019
readufo.c * converted to using space instead of tabs, removed trailing whitespace * removed unused code and code that has no effect * fixed uninitialized/garbage values * fixed potential null pointer dereferences * fixed long vs. int issues * added a missing switch case * fixed code for replacing copyright symbol (©) with the word "Copyright" in trademark strings pubtypes.h & supportpublictypes.h * removed unused typedefs for PVoidProc which were causing Xcode warnings tx_test.py & tx_data/* * added tx test case for copyright symbol (©) handling differ.py * added safeguard against failing to read text file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@miguelsousa (et al.), I'll be making a series of changes in
uforead.c, cleaning up various issues in the code, in the hopes of fixingtx. I'm doing this one step at a time to check the effect each change has on AppVeyor (and Travis). I'll let you know when I'm done.UPDATE: I'm broadening the scope to include other modules used by
tx.