[tx] Make CharString length check a warning rather than a fatal error #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cjchapman I think I know why Travis didn't kick in. Looking into it now. |
(also incorporated some feedback from @miguelsousa, re: test name, comments, etc.)
miguelsousa
requested changes
Jun 27, 2018
Tests/tx_test.py
Outdated
| actual_path = runner(CMD + ['-o', '0', '-f', 'CJK-VarTest.otf']) | ||
| expected_path = _get_expected_path('CJK-VarTest.txt') | ||
| skip = ['-s', '## Filename'] | ||
| assert differ([expected_path, actual_path] + skip) |
There was a problem hiding this comment.
you don't need to define skip
There was a problem hiding this comment.
I think I do. If I comment it out, I get:
def test_long_charstring_bug444():
# read a CFF2 VF with a charstring longer that 65535, check output
actual_path = runner(CMD + ['-o', '0', '-f', 'CJK-VarTest.otf'])
expected_path = _get_expected_path('CJK-VarTest.txt')
# skip = ['-s', '## Filename']
> assert differ([expected_path, actual_path] + skip)
E NameError: global name 'skip' is not defined
There was a problem hiding this comment.
sorry what I meant was, just do
assert differ([expected_path, actual_path, '-s', '## Filename'])
miguelsousa
approved these changes
Jun 27, 2018
|
@cjchapman it just occurred to me that |
miguelsousa
changed the title
miguelsousa
added a commit
that referenced
this pull request
Sep 7, 2018
miguelsousa
added a commit
that referenced
this pull request
Sep 7, 2018
This is the writing counterpart of #446
miguelsousa
added a commit
that referenced
this pull request
Sep 7, 2018
miguelsousa
added a commit
that referenced
this pull request
Sep 7, 2018
This is the writing counterpart of #446
miguelsousa
added a commit
that referenced
this pull request
Sep 7, 2018
miguelsousa
added a commit
that referenced
this pull request
Sep 7, 2018
This is the writing counterpart of #446
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #444