makeotf fixes for #281 and #282 #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it behave the same as when a Type 1 font with no '/FontName' is used as input Fixes #282
miguelsousa
force-pushed
the
makeotf-fix282
branch
from
1ed5d59
to
603c385
Compare
miguelsousa
changed the title
cjchapman
approved these changes
Jun 29, 2018
|
@cjchapman there's a lot of stuff in that file I don't want us to spend time fixing because I'd rather invest the time on a rewrite from the ground up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #281 and #282