Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed some tx issues #452

Merged
merged 17 commits into from
Jun 29, 2018
Merged

fixed some tx issues #452

merged 17 commits into from
Jun 29, 2018

Conversation

cjchapman
Copy link
Contributor

  • UFO3 anchor points no longer crash tx
  • UFO2 anchor points no longer affect font bounding box
  • font bounding boxes no longer have spurious zero coordinates
  • added a disclaimer about FontBBox in AFM output

miguelsousa and others added 15 commits June 20, 2018 09:15
@miguelsousa
[tx] Test case for ufo3 to type1 conversion
f1fa977
@cjchapman
make "parseGlyphOutline: unhandled token" a fatal error
f0b0380
@miguelsousa
[tx_tests] Correct FontBBox values in expected files
ff77976
@cjchapman
initialize bounding box coordinates to +/-FLT_MAX instead of zeros so…
14daab8 
… that bounding box calculations work correctly
@cjchapman
initialize bounding box coordinates to +/-FLT_MAX instead of zeros so…
2cad80b 
… that bounding box calculations work correctly
@cjchapman
fixed a typo in a comment
570196e
@cjchapman
first pass at UFO 3 anchor record parsing:
fbb7b56 
currently parsing the data from the source and storing it in an anchor record struct, then throwing it away,
to do: append the anchor record to a dynamic array in (or associated with) the glyph record
@miguelsousa
[tx_tests] Add empty arrays to UFO input files
f235281 
Related to #339
@cjchapman
postscriptFamilyOtherBlues is an empty array in the input font, so it…
7502963 
… doesn't get written to the output font
@cjchapman
added handling of <array/>
36eddcb
@cjchapman
do not include UFO2 anchor points in font bounding box:
8e0ef7d 
don't update bounds after a moveTo, but do update before (not just after) lineTo
(curveTo already captures its full extents)
@cjchapman
remove postscriptFamilyOtherBlues from expected output
006b3ac 
(as it's an empty array in the input)
@cjchapman
remove postscriptFamilyOtherBlues from expected output
bbc8f1b 
(as it's an empty array in the input)
@cjchapman
added a disclaimer comment about FontBBox values to AFM output of tx
2712072
@miguelsousa
[makeotf_tests] Update FontBBox of expected OTFs
1cca196 
that originated from UFO sources
@miguelsousa miguelsousa merged commit b1699f5 into develop Jun 29, 2018
@miguelsousa miguelsousa deleted the tx-ufo3 branch June 29, 2018 22:11
@cjchapman cjchapman mentioned this pull request Jun 29, 2018
Closed
@frankrolf frankrolf mentioned this pull request Jul 16, 2018
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelsousa miguelsousa miguelsousa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjchapman @miguelsousa