[makeotfexe] Fix issue #456: negative widths are written as large numbers. #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelsousa
requested changes
Jul 6, 2018
|
@readroberts thanks, I'll takeover this branch. #458 needs to be merged first. |
… large glyph advance widths makeotfexe wrote negative values into an unsigned short field, resulting in a value of (65536 - value). makeotfexe now sets negative values to 0, and issues a warning.
miguelsousa
force-pushed
the
makeotf-negative-width-fix
branch
from
e02429a
to
319c1a2
Compare
miguelsousa
approved these changes
Jul 10, 2018
cjchapman
approved these changes
Jul 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makeotfexe wrote negative values into an unsigned short field, resulting in a value of (65536 - value). makeotfexe now sets negative values to 0, and issues a warning.