Fix incorrect warning when converting to CFF a CFF2 variable font with non-varying glyphs #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@readroberts you can take care of this branch now |
|
Will do. I need to add the fix into 'tx' on this branch. |
readroberts
previously approved these changes
Jul 12, 2018
miguelsousa
commented
Jul 12, 2018
| @@ -986,6 +986,14 @@ static float var_applyDeltasForIndexPair(ctlSharedStmCallbacks *sscb, var_itemVa | |||
| } | |||
|
|
|||
| subtable = &dataList->ivdSubtables.array[pair->outerIndex]; | |||
|
|
|||
| /* If specific glyphs do not have any variation, may will be | |||
There was a problem hiding this comment.
@msousa Done - please check.
…e non-varying glyphs A glyph which is non-varying in a variable font may be referenced by a VariationStore data item subtable which has a region count of 0. The VF support code assumed that this was an error, and issued a false warning.
miguelsousa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.