Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[checkoutlinesufo] Support processing UFO3 fonts #482

Merged
merged 4 commits into from
Jul 16, 2018
Merged

[checkoutlinesufo] Support processing UFO3 fonts #482

merged 4 commits into from
Jul 16, 2018

Conversation

miguelsousa
Copy link
Member

@miguelsousa miguelsousa commented Jul 14, 2018 •
edited
Loading

Fixes #477

frankrolf
frankrolf approved these changes Jul 16, 2018
View reviewed changes
Copy link
Member

@frankrolf frankrolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the latest version with a UFO3 file I’m working on, and it works just like with a UFO2 file.
In addition to normal operation (-e) I also tested the -w option (write result in main layer), which also works.

@cjchapman
Copy link
Contributor

@miguelsousa Looks good to me. I leave it to you to merge it whichever way you like.

@miguelsousa miguelsousa merged commit 4e7943e into develop Jul 16, 2018
@miguelsousa miguelsousa deleted the ufo3-checkoutlinesufo branch July 16, 2018 23:07
@frankrolf frankrolf mentioned this pull request Jul 16, 2018
Closed
5 tasks
@miguelsousa miguelsousa mentioned this pull request Jul 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankrolf frankrolf frankrolf approved these changes

@cjchapman cjchapman cjchapman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miguelsousa @cjchapman @frankrolf