[tx] fix for crash when tx calls fatal() #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Substituted a call to exit() instead of longjmp() in all the fatal() functions. There are no a tests, as the only reliable test case to force the crash was removed when issue 444 was fixed. Instead, I provided tests in a branch called 'test-for-issue445', which branched from 'develop' before the fix for issue 444. The branch 'test-for-issue445' contains a test for causing the crash before the fix is applied, and a test for verifying that the correct exit code is supplied after the fix is applied. Note that some white space changed in 'except.c' in lines other than the fixed line; this was to make all the lines in the block have the same white space.
miguelsousa
approved these changes
Jul 18, 2018
cjchapman
approved these changes
Jul 18, 2018
|
@readroberts I'm going to delete the branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue 445. Substituted a call to exit() instead of longjmp() in all the fatal() functions.
There are no tests, as the only reliable test case to force the crash was removed when issue 444 was fixed. Instead, I provided tests in a branch called 'test-for-issue445', which branched from 'develop' before the fix for issue 444. The branch 'test-for-issue445' contains a test for causing the crash before the fix is applied, and a test for verifying that the correct exit code is returned after the fix is applied.
Note that some white space changed in 'except.c' in lines other than the fixed line; this was to make all the lines in the block have the same white space.