[makeotfexe] Allow mark-to-base statements to reference different sets of mark classes. #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makeotf posts a fatal error for mark-to-base or mark-to-mark substitutions, if two statements in the same lookup do not reference the same list of mark classes. Validate that this happens.
makeotf posts a fatal error for mark-to-base or mark-to-mark substitutions, if two statements in the same lookup do not reference the same list of mark classes. Changed GPOS.c to allow this, and to write an offset of 0 for the unused anchor offsets in the each BaseRecord. Added test for expected GPOS.c output. This matches the output from Google's fontmake for the same test case.
miguelsousa
approved these changes
Jul 20, 2018
There was a problem hiding this comment.
@readroberts I think you knocked this one out of the ballpark as well 👏
cjchapman
approved these changes
Jul 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #416. Allow mark-to-base and make-to-mark statements to reference different sets of mark classes.