Fix bug where colon in ufo font glyph name causes crash #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test to validate crash with test file before code fix.
Fix flake8 bugs in test to validate crash with test file before code fix.
If the glyph name contained any of the illegal characters, the code would endlessly add '_' to the glyph name, overrunning the name buffer. Also fixed bug where code that is supposed to handle a too-long name failed. Fixed input_data/bug473.ufo glyph order names. Added expected_output data, and changed test to test for success.
miguelsousa
previously approved these changes
Jul 27, 2018
cjchapman
approved these changes
Jul 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #473. If the glyph name contained any of the illegal characters, the code would endlessly add '_' to the glyph name, overrunning the name buffer.