[spot] Fix abort trap with NotoNastaliqUrdu #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test to validate failure of spot in this test case. When dumping a format 2 PosRule from a lookup Type 7, spot was writing past the end of a fixed length string buffer and destroying the stack.
Fix test to validate failure of spot in this test case - did not fail with crash because spot reported that output file was bad in Appveyor run.
Fix test to validate failure of spot in this test case - on Windows, needed to overrun by the buffer by more than 1K.
Fix text buffer overrun by writing it out whenever the buffer gets close to its limit, Change test to validate success of spot in this test case.
miguelsousa
requested changes
Aug 1, 2018
tests/spot_test.py
Outdated
| def test_bug465(): | ||
| """ Fix bug where a fixed length string buffer was overrun. The test | ||
| font was built by building an otf from | ||
| makeotf/data/innput/t1pfa.pfa, dumping this to ttx, and then |
There was a problem hiding this comment.
inaccurate path, which also includes a typo
tests/spot_test.py
Outdated
| hand-editing the ttx file to have empty charstrings, and a | ||
| ContextPos lookup type 7, format 2. Hand-editing the ttx was needed | ||
| as makeotf does not build this lookup type, nor this post rule | ||
| format. This test validates that the current spot code fails with |
There was a problem hiding this comment.
this description is now outdated
There was a problem hiding this comment.
Fixed in most recent commit.
Fix test to validate success of spot in this test case: correct typo, and that the tests requires success rather than failure.
cjchapman
suggested changes
Aug 1, 2018
c/spot/source/GPOS.c
Outdated
| if ((psIndex + strlen(name2) + 10) >= kProofBufferLen) | ||
| { | ||
| if (level == 7) | ||
| fprintf(OUTPUTBUFF, "\n %s", proofString); |
There was a problem hiding this comment.
Please change line 3581 to use spaces instead of a tab character in the output string.
(Line 3592, which is otherwise identical, uses spaces instead of a tab in the output string.)
Fix spacing in message string. GPOS.c
Updated expected output file to match previous six spacing in message string. GPOS.c.
miguelsousa
previously approved these changes
Aug 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #465 [spot] Abort trap with NotoNastaliqUrdu
Fix text buffer overrun by writing it out whenever the buffer gets close to its limit.
Add test.