-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[makeotf] Fix '-cn' option #525
Conversation
a70f30b
to
ad24cf6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The two problems below are not in the section you changed, but since you're doing this level of cleanup, I think it would be good to fix these (and to make sure we have a test that hits this code, as apparently we don't):
This call in ufotools.py, starting at line 1007 is wrong:
fdGlyphDict, fontDictList, finalFDict = \
convertfonttocid.parseFontInfoFile(
fontDictList, fontInfoData, glyphList,
maxY, minY, psName, blueFuzz)
parseFontInfoFile()
doesn't take so many arguments, I think the fontDictList
is the spurious one.
Also, this code in ufotools.py
starting at line 1017 is wrong:
convertfonttocid.mergeFDDicts(
[finalFDict], self.topDict)
as topDict is not defined anywhere.
|
Fixes makeotf's option that converts the OTF's CFF (name-keyed) table to a CID-keyed CFF table.
Also took the opportunity to do other small fixes and clean-ups.
Fixes #470