Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[makeotf] Fix '-cn' option #525

Merged
merged 5 commits into from
Aug 7, 2018
Merged

[makeotf] Fix '-cn' option #525

merged 5 commits into from
Aug 7, 2018

Conversation

miguelsousa
Copy link
Member

Fixes makeotf's option that converts the OTF's CFF (name-keyed) table to a CID-keyed CFF table.
Also took the opportunity to do other small fixes and clean-ups.
Fixes #470

Copy link
Contributor

@cjchapman cjchapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two problems below are not in the section you changed, but since you're doing this level of cleanup, I think it would be good to fix these (and to make sure we have a test that hits this code, as apparently we don't):

This call in ufotools.py, starting at line 1007 is wrong:

                fdGlyphDict, fontDictList, finalFDict = \
                    convertfonttocid.parseFontInfoFile(
                        fontDictList, fontInfoData, glyphList,
                        maxY, minY, psName, blueFuzz)

parseFontInfoFile() doesn't take so many arguments, I think the fontDictList is the spurious one.

Also, this code in ufotools.py starting at line 1017 is wrong:

                    convertfonttocid.mergeFDDicts(
                        [finalFDict], self.topDict)

as topDict is not defined anywhere.

@miguelsousa
Copy link
Member Author

ufotools.UFOFontData.getfdInfo() seem to be used by autohint and stemhist.
I've opened #531 to address those fixes separately from this PR.

@miguelsousa miguelsousa merged commit 86d65e8 into develop Aug 7, 2018
@miguelsousa miguelsousa deleted the fix-mkot-470 branch August 7, 2018 20:25
miguelsousa added a commit that referenced this pull request Aug 16, 2018
Reverts some of the changes made in #525 which had the side effect of breaking autohinting fonts when a 'fontinfo' file is present.
This also restores the "FinalFont" FDDict functionality.

Fixes #531
miguelsousa added a commit that referenced this pull request Aug 16, 2018
Reverts some of the changes made in #525 which had the side effect of breaking autohinting fonts when a 'fontinfo' file is present.
This also restores the "FinalFont" FDDict functionality.

Fixes #531
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[makeotf] '-cn' option is broken
2 participants