Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[autohint] Fix temp files solution #534

Merged
merged 1 commit into from
Aug 8, 2018
Merged

Conversation

miguelsousa
Copy link
Member

Fixes #244

Copy link
Contributor

@cjchapman cjchapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • need to add import of TTLibError from fontTools, as it is used in openOpenTypeFile() -- line 969
  • fontFileName is undefined in openOpenTypeFile() -- line 975
  • kProcessedGlyphsLayer is not used and should not be imported
  • sys, os, re, time, tempfile, and warnings are not used and should not be imported

@miguelsousa
Copy link
Member Author

@cjchapman autohint is due to be replaced with psautohint. I don't think the fixes and clean ups you listed are worth doing.

@cjchapman
Copy link
Contributor

@miguelsousa OK. For the record, I'm approving this PR on the basis that the issues I'm concerned about are not in the areas changed by the PR. :-)

@miguelsousa
Copy link
Member Author

@cjchapman don't worry, these shaddy approvals shall not taint your reputation 😜

@miguelsousa miguelsousa merged commit 4b5e3b6 into develop Aug 8, 2018
@miguelsousa miguelsousa deleted the fix-autohint-244 branch August 8, 2018 18:09
@cjchapman
Copy link
Contributor

@miguelsousa It's the whole public record thing that worries me, e.g. what if my daughter reads this someday and says, "Seriously Dad, you approved this?!" 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants