[type1] Implement '-h' option. Fix exit code for known options #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjchapman
suggested changes
Aug 8, 2018
c/type1/source/type1.c
Outdated
| } else | ||
| usage(); | ||
| return 0; | ||
| } else |
There was a problem hiding this comment.
Codacy sort of hints at the problem here, which is that you need to add some braces after your else and between the return statements, i.e.:
} else {
usage();
return 1;
}
return 0;
}There was a problem hiding this comment.
👍 in that case I need to add braces to detype1.c as well.
Completes fix for #347
cjchapman
approved these changes
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes fix for #347