[tx] Subroutinization results differ with environment #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjchapman
previously approved these changes
Aug 9, 2018
Add test case to test/tx_test.py in order to validate existence of bug. The bug is that two subr's in the win output cff are swapped in index order from the Mac version. This is because of an unstable qsort done on the subroutines in the final stage of selection.
The bug is that two subr's in the win output cff are swapped in index order from the Mac version. This is because of an unstable qsort done on the subroutines in the final stage of selection. Fix bug by adding a field to the sorted items which reflects original order, and sort by that field when the other items compare equal. Bump version of cffwrite library Update test to verify that both Mac and Win produce same font file.
Trivial change in comments to trigger branch rebuild.
miguelsousa
force-pushed
the
fix-bug494-tx
branch
from
74e3c09
to
04b9913
Compare
miguelsousa
approved these changes
Aug 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #494
The bug is that two subr's in the win output cff are swapped in index order from the Mac version. This is because of an unstable qsort done on the subroutines in the final stage of selection.
Fix bug by adding a field to the sorted items which reflects original order, and sort by that field when the other items compare equal.
Bump version of cffwrite library