Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stemhist] Integration tests & fixes #552

Merged
merged 6 commits into from
Aug 13, 2018
Merged

[stemhist] Integration tests & fixes #552

merged 6 commits into from
Aug 13, 2018

Conversation

miguelsousa
Copy link
Member

No description provided.

Copy link
Contributor

@cjchapman cjchapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not in the parts you changed, but here, for the record, are the things that concern me most in stemhist.py:
193 -- print statement needs paretheses
205 -- exe_dir undefined
463 -- TTLibErorr undefined
469 -- fontFileName undefined

Since this is going to be replaced by psautohint, I'm going to try not to worry about it too much. 😝

@khaledhosny
Copy link
Collaborator

Note that it is still possible to build autohintexe from psautohint repo and use it as a drop-in replacement of the current one, without importing any of the changed Python code. At least in theory, I haven’t tried that in a while. Worth considering as a way to kill autohint earlier with little disruption.

@khaledhosny
Copy link
Collaborator

I just tried that and it seems to work with the few fonts I threw on it.

@miguelsousa
Copy link
Member Author

@khaledhosny would you be opposed to including autohintexe in the psautohint wheel, at least for a period of time? Not having to build autohintexe from the afdko repository would allow us to nuke that old source code, and enable a progressive transition. Is this something that you can setup?

@khaledhosny
Copy link
Collaborator

No objection, though I don’t know how to that (and the current build system I have for building autohintexe is not the most Windows friendly).

@miguelsousa
Copy link
Member Author

OK. For now I'm going to open an issue to track it.

@miguelsousa
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants