[makeotfexe] Only first ligature caret in first ligature is used. #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that the intent of the original code not only had a bug that allowed only one ligature entry to be written, but the intent was also in error. In reviewing the OpenType GDEF table spec and the feature file syntax, I see that a ligature glyph is NOT allowed to have more than one ligature glyph table. For example, 'ffi' cannot have two ligature glyph tables, each with a different format. Fixed issue in feat.c/GDEF.c/featgram.g. Fixed warnings from cppcheck in GDEF.c Updated the makefile for the ANTLR grammar generator to run the clean-up tools cpplint and clang-format after generating the feat*.[ch] files. Update the readme file to note the addition of the cpplint and clang-format commands, and how to install them. Also mentioned that a few style errors are not fixed by clang-format, and must be fixed by hand. Changed argument name in makeotfexe_test.py to something other than a built-in name. Updated the expected output files. Fixes #155
miguelsousa
force-pushed
the
gdef-bug155
branch
from
78a249f
to
b8c6ffb
Compare
miguelsousa
approved these changes
Aug 15, 2018
cjchapman
approved these changes
Aug 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[makeotfexe] Only first ligature caret in first ligature is used. Issue #155.
Fixed issue in feat.c/GDEF.c/featgram.g.
Note that the intent of the original code not only had a bug that allowed only one ligature entry to be written, but the intent was also in error. In reviewing the OpenType GDEF table spec and the feature file syntax, I see that a ligature glyph is NOT allowed to have more than one ligature glyph table. For example, 'ffi' cannot have two ligature glyph tables, each with a different format.