Python 3 support #593
Merged
Python 3 support #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelsousa
force-pushed
the
py3-support
branch
from
a3437f9
to
7f436c1
Compare
|
The mismatch in the sorting of anchors in glif files is due to a bug in fontMath's |
cjchapman
previously approved these changes
Aug 28, 2018
miguelsousa
force-pushed
the
py3-support
branch
from
7f436c1
to
d567d06
Compare
Currently skipping cp36-win_amd64 and building only cp36-win32. The former is the one we want, but can't be built because of autohintexe. The Visual Studio files are also missing x64 Release|Debug configurations.
Contains the fix to the anchors' ordering robotools/fontMath#124
miguelsousa
force-pushed
the
py3-support
branch
from
07247c2
to
f73da90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All is working except:
makeinstancesufo_test.pyis failing on Py3 because of a mismatch in the sorting of anchors in glif files. There could be other hidden issues.autohintexecan only be built as 32bittest_path_with_non_ascii_chars_bug222is marked as a pytest.xfail on Windows Python 3.6otc2otfandotf2otchave not been tested, so most likely don't support Py3 yet