Fix makeotfexe return values #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelsousa
force-pushed
the
fix-makeotfexe-return-values
branch
from
36e0dd7
to
a48eca6
Compare
makeotfexe should return 0 with the options -u and -h. It should return 1 if a the source font file or source feature file is not found. It is valid to not provide any arguments: this is the same as providing a source font file of 'font.ps', and a feature file of 'features'.
miguelsousa
force-pushed
the
fix-makeotfexe-return-values
branch
from
a48eca6
to
b80b034
Compare
cjchapman
previously approved these changes
Sep 13, 2018
miguelsousa
approved these changes
Sep 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makeotfexe should return 0 with the options -u and -h.
makeotfexe should exit with a return value of 1 if the source font file or source feature file is not found.
It is valid to not provide any arguments: this is the same as providing a source font file of 'font.ps', and a feature file of 'features'.