Add Windows x64 configuration #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also did some cleaning up on them
It's a misnomer and totally confusing to name these things 'BuildAll'
If a font has no glyphs which are assigned a Unicode value, either implicitly from having ASCII range characters, or via the GOADB file, a pointer is set to reference to whatever is in memory just before the array which is supposed to contain the UVs. On the Mac, and I imagine in prior build environments, the referenced value happens to 0, when running under 64 bit Windows, this memory os non-zero, and causes a crash. The fix is simply to skip the logic that process the array of Unicode values, when there aren't any. The bug was in in map.c::setOS_2Fields().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.