Misc waterfallplot and proofpdf fixes #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The number in the page header referring to the total page count was not always correct.
Waterfalls whose text string was longer than 126 characters were displaying a repeated glyph after the 127th character. Fixed by using 'latin-1' encoding instead of 'utf-8', when writing that section of the PDF.
Besides simplifying the opening commands, fixes a traceback that happened in py3 on Windows due to using 'os.getcwdu()'.
This info is not useful and creates problems when trying to diff results (because even if the element is skipped from the diff, the PDF's xref block will contain many changes)
cjchapman
reviewed
Oct 5, 2018
cjchapman
suggested changes
Oct 5, 2018
|
These files haven't been cleaned up. I'll do that separately, some other day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.