[autohint] Enclose the AUTOHINTEXE path in quotes #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Arnie97 thanks, the patch looks good. There has been a GitHub incident that impacts this PR. We're waiting for the status to go green before merging. |
miguelsousa
approved these changes
Oct 23, 2018
anthrotype
reviewed
Oct 23, 2018
| @@ -1237,7 +1237,7 @@ def hintFile(options): | |||
| else: | |||
| if os.path.exists(tempBezNew): | |||
| os.remove(tempBezNew) | |||
| command = AUTOHINTEXE + " %s%s%s%s -s %s -f \"%s\" \"%s\"" % (verboseArg, suppressEditArg, supressHintSubArg, decimalArg, NEWBEZ_SUFFIX, tempFI, tempBez) | |||
| command = '"%s" %s%s%s%s -s %s -f "%s" "%s"' % (AUTOHINTEXE, verboseArg, suppressEditArg, supressHintSubArg, decimalArg, NEWBEZ_SUFFIX, tempFI, tempBez) | |||
There was a problem hiding this comment.
if you called the subprocess with a list of strings instead a single string, then subprocess would take care of the quoting for you
There was a problem hiding this comment.
autohint.py is on the chopping block
There was a problem hiding this comment.
and fdkutils.runShellCmd is used in many places; any changes to it need to be done carefully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#606 (comment)