Improvements to makeinstancesufo #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* -dec/-decimal option was changed to -r/--no-round * removed undocumented -log option * removed -u option * added --version and -v/--verbose options (The default now is "quiet mode")
According to http://unifiedfontobject.org/versions/ufo3/layercontents.plist/ the directory name (2nd string) is derived from the layer name (1st string) and prefixed with "glyphs.". To make this change have the least impact, the name of the directory was kept while the name of the layer got changed. However, 'processedGlyphs' was changed to 'processedglyphs' to avoid the directory name to be normalized to 'processedG_lyphs'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple more steps toward addressing #402.
Notable changes:
-dec/-decimaloption was changed to-r/--no-round-logoption-uoption--versionand-v/--verboseoptions (The default now is "quiet mode")checkoutlinesufoas a module instead of running it viasubprocess