Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ufolib #669

Merged
merged 6 commits into from
Dec 5, 2018
Merged

Remove ufolib #669

merged 6 commits into from
Dec 5, 2018

Conversation

miguelsousa
Copy link
Member

Fixes #666

* adds 'lxml' extra to defcon and fontTools
* adds 'pens' extra to defcon and remove explicit fontPens dependency
* adds 'cli' extra to cu2qu; it's useful for development
* keeps ufoLib pinned; it will be removed in a following step
* XML header: double quotes → single quotes
* UFO creator: org.robofab.ufoLib → com.github.fonttools.ufoLib
* removed empty layerinfo.plist file
@miguelsousa
Copy link
Member Author

@anthrotype do you know how to fix the Windows failures?
I made some changes to address the paths must be unicode (not str) problem, but now test_path_with_non_ascii_chars_bug222 is failing with the UFO files on Windows. This particular test was already turned off on py36. AFAIK it has something to do with the encoding of the console not being utf-8.

@miguelsousa
Copy link
Member Author

miguelsousa commented Nov 4, 2018

ufoLib is still being installed by psautohint (v1.8.1) and fontPens (v0.1.0, via defcon), so it's possible that the expected results will need to be adjusted once those packages get updated.

@miguelsousa miguelsousa merged commit 8817dc8 into develop Dec 5, 2018
@miguelsousa miguelsousa deleted the remove-ufolib branch December 5, 2018 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transition from ufoLib to fontTools.ufoLib
1 participant