Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #685 [tx] subroutinizer 64K limit #687

Merged
merged 2 commits into from
Nov 30, 2018
Merged

Conversation

blueshade7
Copy link
Contributor

use "unsigned" in place of "unsigned short" as type of offsets and lengths
verified the fix using the attached CFF2 font uni7e7c.otf

use "unsigned" in place of "unsigned short" as type of offsets and lengths
cjchapman
cjchapman previously approved these changes Nov 29, 2018
Copy link
Contributor

@cjchapman cjchapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blueshade7 I'm OK with the change as it is now, so I'll approve, but I'd like it even better if you used uint32_t and int32_t instead of unsigned and int in order to make the bits needed explicit. I'm trying to make similar changes throughout the code base when I work on size related issues like this one. Thanks for considering this request.

readroberts
readroberts previously approved these changes Nov 29, 2018
Copy link
Contributor

@readroberts readroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll second Chris. Going forward, when you need to edit any code, please change to uint32_t and int32_t types. I will try and remember this as well. Otherwise, this is a simple change and looks good. I'm marking it approved so that you cam squash and merge when you are done.

@blueshade7
Copy link
Contributor Author

OK I re-worked it to use explicit sized types.

@blueshade7 blueshade7 merged commit 6b49b17 into develop Nov 30, 2018
@blueshade7 blueshade7 deleted the fix_subrize64k branch November 30, 2018 00:14
@cjchapman
Copy link
Contributor

@blueshade7 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants