Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert OpenType Feature File specification to Markdown #777

Merged
merged 27 commits into from
Mar 22, 2019

Conversation

miguelsousa
Copy link
Member

Continuation of #776

@miguelsousa
Copy link
Member Author

@frankrolf I'm done with my changes and also implemented Read's suggestions.

Unless you have further tweaks, I think the only remaining item is the TOC.

@frankrolf
Copy link
Member

@miguelsousa Thank you for this. I think changing the TOC to match the system proposed in the document structure might not be possible – I tried it earlier.
As of this moment, the TOC is just a system of nested, numbered lists like this:

  1. item one
  2. item two
    1. item two_one
    2. item two_two
      1. item two_two_one
      2. item two_two_two
      3. item two_two_three
    3. item two_three
  3. item three

The GitHub markdown parser decides to put lowercase Roman numerals first, then alphabetic indexing – opposite to the way the spec works at the moment. The source code for the TOC is purely numerical:

1. item one
2. item two
    1. item two_one
    2. item two_two
        1. item two_two_one
        2. item two_two_two
        2. item two_two_three
    3. item two_three
3. item three

I tried to match that code to what’s set up in the document itself, but it breaks the whole system.
I am glad to update the numbering structure within the document to match whatever GitHub is proposing, but I think it may be different in another markdown interpretation.

@miguelsousa
Copy link
Member Author

Thanks, I'll look into it. I'd like to try some stuff.

@miguelsousa miguelsousa force-pushed the ot_spec_markdown branch 3 times, most recently from a70367a to 44a2688 Compare March 22, 2019 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants