[mergefonts] explicitly zero out new dynamic array memory #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fixes an instance of "ERROR: AddressSanitizer: stack-buffer-overflow"
this fixes an instance of "ERROR: AddressSanitizer: heap-use-after-free"
this fixes semi-random instances of "charstring parse error" in mergefonts
miguelsousa
approved these changes
May 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary change in this PR is the addition of code to explicitly set new memory to zero when a dynamic array grows. This fixes a bug in
mergefontsin which it would fail on a semi-random glyph with the messagemergefonts: (cfr) charstring parse error.In the process of tracking down that problem, I fixed a couple of other memory issues which reported by Xcode's memory diagnostics. One was memory that was getting freed before it was used. The other was an incorrect variable type that was causing a pointer alignment issue.
Along the way, I also updated several Xcode project files semi-automatically with the changes recommended by Xcode 10.2.1.