Fix mark to base bug #815
Merged
Fix mark to base bug #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@readroberts can the tests be for |
|
Also, should |
readroberts
force-pushed
the
fix-MarkToBase-bug
branch
from
973f5e0
to
368464a
Compare
Fix afdko issue Bug in building MarkToBase lookup type 4 #811. In fillMarkToBase(), If a base record does not have anchor for a given mark class, the logic assigns it an offset of 0. Later, in writeMarkToBase(), an offset of 0 for a base anchor record is used as a flag to write a NULL anchor record. There are several parts to how the bug happens. First, the offset to the first mark anchor record is always zero. This is not a problem for the array of offsets to the mark anchor records, as the logic assumes these are never NULL. Second, the the anchor offset array is filled first with the mark anchor records, and then extended with the base anchor records. Third, when the base anchor records are processed, the code tries to find a match for the current base anchor record's coords in the anchor record array; if a match is found, the offset for that anchor record is used. This means that if a base anchor record's coords match the coords of the first mark anchor record, the offset for the baser anchor record will be set to the same as that of the first mark anchor record - which is zero. In writeMarkToBase(), this valid offset is then interpreted as flagging a NULL anchor. I think this bug was added by me on 5/9/2016 commit [20af6dd], when I changed the handling of empty mark records.
readroberts
force-pushed
the
fix-MarkToBase-bug
branch
from
368464a
to
2210a9a
Compare
|
@miguelsousa Agreed on both comments. Moved test to makeotfexe_test.py, bumped HOT_VERSION. Force-pushed clean branch. |
miguelsousa
force-pushed
the
fix-MarkToBase-bug
branch
from
2210a9a
to
fd85b28
Compare
miguelsousa
approved these changes
Jun 20, 2019
cjchapman
approved these changes
Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.