Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tx] fix SetNumMasters call to var_getIVSRegionIndices #835

Merged
merged 1 commit into from
Jul 11, 2019

Conversation

cjchapman
Copy link
Contributor

SetNumMasters was incorrectly passing the number of region indices to var_getIVSRegionIndices for the regionListCount. With this change it now passes the total region count for regionListCount.

Example symptoms of the bug:

tx: (cfr) inconsistent region indices detected in item variation store subtable 1
tx: (cfr) memory error

Copy link
Contributor

@blueshade7 blueshade7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we need a test case

SetNumMasters was incorrectly passing the number of region indices to var_getIVSRegionIndices for the regionListCount. With this change it now passes the total region count for regionListCount.
@cjchapman
Copy link
Contributor Author

@blueshade7 Yes, thanks for the reminder. I've amended the commit with a test case.

Copy link
Contributor

@blueshade7 blueshade7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@cjchapman cjchapman merged commit c0f3130 into develop Jul 11, 2019
@cjchapman cjchapman deleted the cjc-fix-tx-setnummasters branch July 11, 2019 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants