Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tx -no_opt & cffwrite CFW_NO_OPTIMIZATION descriptions #938

Merged
merged 2 commits into from
Aug 28, 2019

Conversation

blueshade7
Copy link
Contributor

Added a description of -no_opt option to tx -cff help.
Added a description of CFW_NO_OPTIMIZATION flag to cffwrite header file cffwrite.h.

@miguelsousa
Copy link
Member

@blueshade7 do you know how -no_opt differs from +/-T optimize charstrings ?

@blueshade7
Copy link
Contributor Author

I see in cff.c, -T sets CFW_NO_FAMILY_OPT and CFW_ENABLE_CMP_TEST, +T resets both (default).

Each description in cffwrite.h says:
CFW_NO_FAMILY_OPT Don't apply family value optimizations
CFW_ENABLE_CMP_TEST Enable testing by disabling optimizations

-/+T sets/resets T1W_ENABLE_CMP_TEST for Type1 output and its description in t1write.h says:

When bit 12 is set several optimizations are disabled so as to enable
rendering comparison tests to succeed. Do not use in production code.

There is no Type1 counterpart for CFW_NO_FAMILY_OPT.
So sounds like -T is to minimize unwanted diffs in a bit-to-bit rendering comparison of some sort. I guess “T” stands for “Test”.

The current description of -/+T seems wrong. Unrelated to charstring optimization.
I think it needs to be updated too.

Copy link
Member

@miguelsousa miguelsousa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification

@miguelsousa miguelsousa merged commit 158b6cc into develop Aug 28, 2019
@miguelsousa miguelsousa deleted the no_opt_desc branch August 28, 2019 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants