Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tx] improve handling of vsindex in dumpCstr #958

Merged
merged 1 commit into from
Sep 6, 2019
Merged

[tx] improve handling of vsindex in dumpCstr #958

merged 1 commit into from
Sep 6, 2019

Conversation

cjchapman
Copy link
Contributor

  • pop value off top of stack instead of pulling from bottom of stack
  • check that vsindex value is within varRegionInfo array

@cjchapman
[tx] improve handling of vsindex in dumpCstr
18c8aa3 
* pop value off top of stack instead of pulling from bottom of stack
* check that vsindex value is within varRegionInfo array
blueshade7
blueshade7 approved these changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@blueshade7 blueshade7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@cjchapman cjchapman merged commit f90cf5c into develop Sep 6, 2019
@cjchapman cjchapman deleted the cjc-improve-handling-of-vsindex-in-dumpCstr branch September 6, 2019 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blueshade7 blueshade7 blueshade7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjchapman @blueshade7