Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[makeotfexe] Import fealib tests #973

Merged
merged 2 commits into from
Sep 30, 2019
Merged

[makeotfexe] Import fealib tests #973

merged 2 commits into from
Sep 30, 2019

Conversation

khaledhosny
Copy link
Collaborator

Some tests required cosmetic changes to TTX output to pass, others had the wrong output from feaLib. The remaining xfail tests test parts of feature files spec not supported by makeotf.

Not wired yet.
Some tests required cosmetic changes to TTX output to pass, others had
the wrong output from feaLib. The remaining xfail tests test parts of
feature files spec not supported by makeotf.
@anthrotype
Copy link
Member

Wrong output from feaLib?

Copy link
Contributor

@cjchapman cjchapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I appreciate the way you structured test_feature_file(). Thanks.

@cjchapman cjchapman merged commit 73c8057 into develop Sep 30, 2019
@cjchapman cjchapman deleted the makeotf-fealib-tests branch September 30, 2019 19:50
@khaledhosny
Copy link
Collaborator Author

Wrong output from feaLib?

fonttools/fonttools#1733 and #967.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants