Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add null check for BG configurationResolver #110

Merged
merged 2 commits into from
Jun 16, 2020
Merged

Add null check for BG configurationResolver #110

merged 2 commits into from
Jun 16, 2020

Conversation

chrischrischris
Copy link
Contributor

Add a null checks for configurationResolver and gradientConfigs

auniverseaway
auniverseaway approved these changes Jun 16, 2020
View reviewed changes
Copy link
Member

@auniverseaway auniverseaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should change this API to jut be, ContextAwarePropertyRetriever or something. The more I think about this, the more I realize this could be generalized for many uses.

I'd still merge this, though.

@chrischrischris chrischrischris merged commit d04eff0 into adobe:master Jun 16, 2020
@chrischrischris chrischrischris deleted the bgGradientNullCheck branch June 16, 2020 18:59
@chrischrischris chrischrischris mentioned this pull request Jun 16, 2020
Closed
@chrischrischris
Copy link
Contributor Author

@auniverseaway Agreed - there is no need for this to be specific to gradients. Filed #111 to track.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auniverseaway auniverseaway auniverseaway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrischrischris @auniverseaway